chrome/browser/resources/gaia_auth_host/authenticator.js - Issue 1021383002: cros: Transfer auth cookies for SAML webview sign-in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/gaia_auth_host/authenticator.js

Issue 1021383002: cros: Transfer auth cookies for SAML webview sign-in. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/helper.cc ('K') | « chrome/browser/resources/chromeos/login/screen_gaia_signin.js ('k') | chrome/browser/ui/webui/chromeos/login/base_screen_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/gaia_auth_host/authenticator.js

diff --git a/chrome/browser/resources/gaia_auth_host/authenticator.js b/chrome/browser/resources/gaia_auth_host/authenticator.js

index e2dc8b69d3b1f5ff64cea31a317d3d5f3eb9ff6e..3fbb07f615d99294368554fb2f6c07f8282a2eb7 100644

--- a/chrome/browser/resources/gaia_auth_host/authenticator.js

+++ b/chrome/browser/resources/gaia_auth_host/authenticator.js

@@ -253,7 +253,7 @@ cr.define('cr.login', function() {

if (history.state && history.state.url != url)

history.pushState({url: url}, '');

else

- history.replaceState({url: url});

+ history.replaceState({url: url}, '');

dzhioev_at_google 2015/03/23 23:01:17 Offtop: Do you know what all these history manipul

xiyuan 2015/03/23 23:10:48 It is for desktop chrome where the sign-in UI coul

dzhioev_at_google 2015/03/23 23:54:23 I afraid this can break OOBE/Login somehow. Probab

};

/**