Issue 102133008: drive: Call OnDirectoryChanged from EntryRevertPerformer

Issue 102133008: drive: Call OnDirectoryChanged from EntryRevertPerformer (Closed)

Created:
7 years ago by hashimoto

Modified:
7 years ago

Reviewers:
kinaba

CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tfarina, haitaol+watch_chromium.org, oshima+watch_chromium.org, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Call OnDirectoryChanged from EntryRevertPerformer BUG=260538 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239192

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use set #

Patch Set 3 : Fix test #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -24 lines)			Patch
M	chrome/browser/chromeos/drive/sync/entry_revert_performer.h	View	1	4 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/entry_revert_performer.cc	View	1 2	3 chunks	+60 lines, -22 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/entry_revert_performer_unittest.cc	View		4 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/entry_update_performer.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/entry_update_performer.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/remove_performer.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/remove_performer.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/remove_performer_unittest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinaba

https://codereview.chromium.org/102133008/diff/1/chrome/browser/chromeos/drive/sync/entry_revert_performer.cc File chrome/browser/chromeos/drive/sync/entry_revert_performer.cc (right): https://codereview.chromium.org/102133008/diff/1/chrome/browser/chromeos/drive/sync/entry_revert_performer.cc#newcode123 chrome/browser/chromeos/drive/sync/entry_revert_performer.cc:123: std::vector<base::FilePath>* changed_directories = Wouldn't it better be std::set? otherwise ...

7 years ago (2013-12-06 07:04:04 UTC) #2

hashimoto

Oops, I added a test code but not run it with the new code... https://codereview.chromium.org/102133008/diff/1/chrome/browser/chromeos/drive/sync/entry_revert_performer.cc ...

7 years ago (2013-12-06 07:36:19 UTC) #3

kinaba

lgtm https://codereview.chromium.org/102133008/diff/1/chrome/browser/chromeos/drive/sync/entry_revert_performer.cc File chrome/browser/chromeos/drive/sync/entry_revert_performer.cc (right): https://codereview.chromium.org/102133008/diff/1/chrome/browser/chromeos/drive/sync/entry_revert_performer.cc#newcode123 chrome/browser/chromeos/drive/sync/entry_revert_performer.cc:123: std::vector<base::FilePath>* changed_directories = On 2013/12/06 07:36:20, hashimoto wrote: ...

7 years ago (2013-12-06 07:41:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/102133008/40001

7 years ago (2013-12-06 09:20:28 UTC) #5

Message was sent while issue was closed.

Change committed as 239192

Expand Messages | Collapse Messages