Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 1021313002: Clear RenderFrameImpl::frame_ pointer after deleting it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2272
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 friend class PepperDeviceTest; 527 friend class PepperDeviceTest;
528 friend class RenderViewImplTest; 528 friend class RenderViewImplTest;
529 friend class RenderViewTest; 529 friend class RenderViewTest;
530 friend class RendererAccessibilityTest; 530 friend class RendererAccessibilityTest;
531 531
532 // TODO(nasko): Temporarily friend RenderFrameImpl, so we don't duplicate 532 // TODO(nasko): Temporarily friend RenderFrameImpl, so we don't duplicate
533 // utility functions needed in both classes, while we move frame specific 533 // utility functions needed in both classes, while we move frame specific
534 // code away from this class. 534 // code away from this class.
535 friend class RenderFrameImpl; 535 friend class RenderFrameImpl;
536 536
537 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, RenderFrameMessageAfterDetach);
537 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, DecideNavigationPolicyForWebUI); 538 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, DecideNavigationPolicyForWebUI);
538 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, 539 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,
539 DidFailProvisionalLoadWithErrorForError); 540 DidFailProvisionalLoadWithErrorForError);
540 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, 541 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,
541 DidFailProvisionalLoadWithErrorForCancellation); 542 DidFailProvisionalLoadWithErrorForCancellation);
542 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, ImeComposition); 543 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, ImeComposition);
543 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, InsertCharacters); 544 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, InsertCharacters);
544 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, JSBlockSentAfterPageLoad); 545 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, JSBlockSentAfterPageLoad);
545 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, LastCommittedUpdateState); 546 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, LastCommittedUpdateState);
546 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnHandleKeyboardEvent); 547 FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnHandleKeyboardEvent);
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 // use the Observer interface to filter IPC messages and receive frame change 1063 // use the Observer interface to filter IPC messages and receive frame change
1063 // notifications. 1064 // notifications.
1064 // --------------------------------------------------------------------------- 1065 // ---------------------------------------------------------------------------
1065 1066
1066 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1067 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1067 }; 1068 };
1068 1069
1069 } // namespace content 1070 } // namespace content
1070 1071
1071 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1072 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698