Enable using the toolchain (llvm) provided FileCheck.

SConstruct

 #! -*- python -*-
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import atexit
 import json
 import os
 import platform
 import re
@@ skipping 1606 matching lines @@
   assert len(node) == 1, node
   return node[0]
 
 pre_base_env.AddMethod(GetTranslatedNexe)
 
 
 def CommandTestFileDumpCheck(env,
                              name,
                              target,
                              check_file,
-                             objdump_flags):
+                             objdump_flags,
+                             use_llvm_filecheck=False):
   """Create a test that disassembles a binary (|target|) and checks for
   patterns in the |check_file|.  Disassembly is done using |objdump_flags|.
   """
 
   # Do not try to run OBJDUMP if 'built_elsewhere', since that *might* mean
   # that a toolchain is not even present.  E.g., the arm hw buildbots do
   # not have the pnacl toolchain. We should be able to look for the host
   # ARM objdump though... a TODO(jvoung) for when there is time.
   if env.Bit('built_elsewhere'):
     return []
   target = env.GetTranslatedNexe(target)
   return env.CommandTestFileCheck(name,
                                   ['${OBJDUMP}', objdump_flags, target],
-                                  check_file)
+                                  check_file, use_llvm_filecheck)
 
 pre_base_env.AddMethod(CommandTestFileDumpCheck)
 
-
-def CommandTestFileCheck(env, name, cmd, check_file):
+def CommandTestFileCheck(env, name, cmd, check_file, use_llvm_filecheck=False):
   """Create a test that runs a |cmd| (array of strings),
   which is expected to print to stdout.  The results
   of stdout will then be piped to the file_check.py tool which
   will search for the regexes specified in |check_file|. """
 
-  return env.CommandTest(name,
+  if use_llvm_filecheck:
+    return env.CommandTest(name,
+                         [env.File('${SCONSTRUCT_DIR}/tools/llvm_file_check_wrapper.sh'),

[Derek Schuff, 2015/03/23 16:25:07]

Why use a wrapper here instead of just invoking ${FILECHECK} directly?

[Mircea Trofin, 2015/03/23 17:27:20]

Because we want to run FileCheck | <dump command>, but all that as a parameter
to the python test wrapper (see CommandTest). Without a wrapper for FileCheck,
the command interpreter takes everything on the left of '|' and pipes it to
everything on the right, which is not what we want.

[JF, 2015/03/23 17:42:10]

you should add this as a comment in the wrapper.

+                         '${FILECHECK}',
+                         check_file] + cmd)
+  else:
+    return env.CommandTest(name,
                          ['${PYTHON}',
-                          env.File('${SCONSTRUCT_DIR}/tools/file_check.py'),
-                          check_file] + cmd,
+                         env.File('${SCONSTRUCT_DIR}/tools/file_check.py'),
+                         check_file] + cmd,
                          # don't run ${PYTHON} under the emulator.
                          direct_emulation=False)
 
 pre_base_env.AddMethod(CommandTestFileCheck)
 
 def CommandSelLdrTestNacl(env, name, nexe,
                           args = None,
                           log_verbosity=2,
                           sel_ldr_flags=None,
                           loader=None,
@@ skipping 2344 matching lines @@
   nacl_env.ValidateSdk()
 
 if BROKEN_TEST_COUNT > 0:
   msg = "There are %d broken tests." % BROKEN_TEST_COUNT
   if GetOption('brief_comstr'):
     msg += " Add --verbose to the command line for more information."
   print msg
 
 # separate warnings from actual build output
 Banner('B U I L D - O U T P U T:')