Issue 1021303002: [V8] Fix messages GetPositionInLine method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1021303002: [V8] Fix messages GetPositionInLine method (Closed)

Created:
5 years, 9 months ago by kozy

Modified:
5 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[V8] Fix messages GetPositionInLine method With this CL method uses location.column instead start_position - location.start . This method uses for v8::Message::GetStartColumn. R=yangguo@chromium.org BUG=chromium:468781 LOG=Y

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/messages.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Yang

5 years, 9 months ago (2015-03-23 09:38:04 UTC) #1

Not sure if I should review this. This looks good, but a test case would be
nice.

Expand Messages | Collapse Messages