Allow arity checks on dynamic function types

Allow arity checks on dynamic function types

BUG=
R=jacobr@google.com, leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/aba10a1a056b77f67237d8e5bfa3cf3f6ee9907d

[vsm, 2015-03-20 16:34:47]

vsm@google.com changed reviewers:
+ jacobr@google.com, leafp@google.com

[Jacob, 2015-03-20 16:41:52]

lgtm

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart
File lib/src/checker/rules.dart (right):

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:137: for (var parameterType in
ft.normalParameterTypes) {
I know this code just moved around but it can be replaced with the cleaner:
return ft.normalParameterTypes.any(predicate) ||
    ft.optionalParameterTypes.any(predicate) ||
    ft.namedParameterTypes.values.any(predicate);

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:538: if (_anyParameterType(ft, (pt) => pt.isDynamic))
return true;
nit... replace with
return _anyParameterType(ft, (pt) => pt.isDynamic);

[vsm, 2015-03-20 17:23:12]

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart
File lib/src/checker/rules.dart (right):

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:137: for (var parameterType in
ft.normalParameterTypes) {
On 2015/03/20 16:41:52, Jacob wrote:
> I know this code just moved around but it can be replaced with the cleaner:
> return ft.normalParameterTypes.any(predicate) ||
>     ft.optionalParameterTypes.any(predicate) ||
>     ft.namedParameterTypes.values.any(predicate);

Done.

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:538: if (_anyParameterType(ft, (pt) => pt.isDynamic))
return true;
On 2015/03/20 16:41:52, Jacob wrote:
> nit... replace with
> return _anyParameterType(ft, (pt) => pt.isDynamic);

Done.

[Leaf, 2015-03-20 17:32:01]

lgtm

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart
File lib/src/checker/rules.dart (right):

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:166: if (!typeArgument.isDynamic) return false;
We could presumably allow object here as well?

[vsm, 2015-03-20 17:39:29]

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart
File lib/src/checker/rules.dart (right):

https://codereview.chromium.org/1021273004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:166: if (!typeArgument.isDynamic) return false;
On 2015/03/20 17:32:01, leafp wrote:
> We could presumably allow object here as well?

Yes, done.  Perhaps we should unify Object and dynamic more generally though.

[vsm, 2015-03-20 17:40:56]

Committed patchset #2 (id:20001) manually as
aba10a1a056b77f67237d8e5bfa3cf3f6ee9907d (presubmit successful).