chrome/browser/net/predictor_browsertest.cc - Issue 1021233003: Disable PredictorBrowserTest.DnsPrefetch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/predictor_browsertest.cc

Issue 1021233003: Disable PredictorBrowserTest.DnsPrefetch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@disable_verifymanagedsignout

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/net/predictor_browsertest.cc

diff --git a/chrome/browser/net/predictor_browsertest.cc b/chrome/browser/net/predictor_browsertest.cc

index 6255237a3c546459c05765349b236d3a681f2743..4db692acbf173da38139f0db21d68398f1003edd 100644

--- a/chrome/browser/net/predictor_browsertest.cc

+++ b/chrome/browser/net/predictor_browsertest.cc

@@ -269,7 +269,13 @@ IN_PROC_BROWSER_TEST_F(PredictorBrowserTest, ShutdownStartupCycle) {

WaitUntilHostHasBeenRequested(target_url_.host());

}

-IN_PROC_BROWSER_TEST_F(PredictorBrowserTest, DnsPrefetch) {

+// Flaky on Windows: http://crbug.com/469120

+#if defined(OS_WIN)

+#define MAYBE_DnsPrefetch DISABLED_DnsPrefetch

+#else

+#define MAYBE_DnsPrefetch DnsPrefetch

+#endif

+IN_PROC_BROWSER_TEST_F(PredictorBrowserTest, MAYBE_DnsPrefetch) {

ASSERT_TRUE(test_server()->Start());

int hostnames_requested_before_load = RequestedHostnameCount();

ui_test_utils::NavigateToURL(

« no previous file with comments | « no previous file | no next file » | no next file with comments »