Source/core/rendering/RenderBox.h - Issue 102123013: Fix painting of fixed background images in composited layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 102123013: Fix painting of fixed background images in composited layers (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixes per review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index e2c06cf1ea8e7b4eccc7be0f1ff7914a35b5f9c8..c8c888aa68fe03d7f1e9e160d9dd73400f8577be 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -631,7 +631,8 @@ protected:

virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE;

virtual void updateFromStyle() OVERRIDE;

- LayoutRect backgroundPaintedExtent() const;

+ // Returns false if it could not cheaply compute the extent (e.g. fixed background), in which case the returned rect may be incorrect.

+ bool getBackgroundPaintedExtent(LayoutRect&) const;

virtual bool foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, unsigned maxDepthToTest) const;

virtual bool computeBackgroundIsKnownToBeObscured() OVERRIDE;