Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 102123002: Enable ASSERT when DCHECK_ALWAYS_ON is defined. (Closed)

Created:
7 years ago by dshwang
Modified:
7 years ago
CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable ASSERT when DCHECK_ALWAYS_ON is defined. It is burdensome to build in debug to check ASSERT. Chromium already has DCHECK_ALWAYS_ON macro to turn on DCHECK even in release build. Blink also enables ASSERT when DCHECK_ALWAYS_ON is defined.

Patch Set 1 #

Patch Set 2 : WIP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
A + Source/build/defines_from_chromium.gypi View 1 2 chunks +16 lines, -8 lines 0 comments Download
M Source/core/core.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core_derived_sources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/platform_derived_sources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/testing/testing.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/web.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/web_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/Assertions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/wtf/wtf.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M public/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M public/blink.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dshwang
7 years ago (2013-12-03 15:20:16 UTC) #1
abarth-chromium
not lgtm DCHECK_ALWAYS_ON is a Chromium concept that Blink should remain ignorant of.
7 years ago (2013-12-03 16:59:10 UTC) #2
dshwang
On 2013/12/03 16:59:10, abarth wrote: > not lgtm > > DCHECK_ALWAYS_ON is a Chromium concept ...
7 years ago (2013-12-03 17:07:59 UTC) #3
dshwang
7 years ago (2013-12-03 19:02:29 UTC) #4
I have investigated more, and I give up it, because so many ASSERT use variables
under NDEBUG guard.

for example,
in WeakPtr.h

#ifndef NDEBUG
        m_boundThread = currentThread();
#endif
  ...
  ASSERT(m_boundThread == currentThread());

Powered by Google App Engine
This is Rietveld 408576698