Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1021213002: [strong] Less pleading error messages (Closed)

Created:
5 years, 9 months ago by rossberg
Modified:
5 years, 9 months ago
CC:
v8-dev, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Less pleading error messages R=dslomov@chromium.org BUG=v8:3956 LOG=N Committed: https://crrev.com/490378ba158eaa4c0fc6fcd976b38cbfc6f1fda1 Cr-Commit-Position: refs/heads/master@{#27338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/messages.js View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 9 months ago (2015-03-20 09:57:59 UTC) #1
Dmitry Lomov (no reviews)
lgtm less pleading is more pleasing
5 years, 9 months ago (2015-03-20 10:21:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021213002/1
5 years, 9 months ago (2015-03-20 10:29:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 10:50:11 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 10:50:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/490378ba158eaa4c0fc6fcd976b38cbfc6f1fda1
Cr-Commit-Position: refs/heads/master@{#27338}

Powered by Google App Engine
This is Rietveld 408576698