Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1021103002: Fix closure compiler in network_list.js. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compiler in network_list.js. The type of fist argument of createVPNConnectionCallback_ is "string=", which is "string|undefined". But the type of extensionID that is passed to the function is "string|null". The CL adds "|| undefined" to the next of extensionID so that it replaces "null" type with "undefined". BUG=None TEST=None TBR=pneubeck@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e8caff36192c96c409acd97e610fd918e7848ea6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/options/chromeos/network_list.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
hirono
@pneubeck - Let me TBR for the nit change.
5 years, 9 months ago (2015-03-20 03:28:28 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e8caff36192c96c409acd97e610fd918e7848ea6 Cr-Commit-Position: refs/heads/master@{#321509}
5 years, 9 months ago (2015-03-20 03:34:36 UTC) #3
hirono
Committed patchset #1 (id:1) manually as e8caff36192c96c409acd97e610fd918e7848ea6 (presubmit successful).
5 years, 9 months ago (2015-03-20 03:34:46 UTC) #4
pneubeck (no reviews)
please explain what the compiler error was and why this fixes the problem.
5 years, 9 months ago (2015-03-20 08:23:06 UTC) #5
hirono
5 years, 9 months ago (2015-03-20 09:43:46 UTC) #6
Message was sent while issue was closed.
On 2015/03/20 08:23:06, pneubeck wrote:
> please explain what the compiler error was and why this fixes the problem.

I updated the CL description. Thanks!

Powered by Google App Engine
This is Rietveld 408576698