Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1021083003: [DevTools] Pause input events in WebFrameWidgetImpl while debugging. (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, dcheng, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, mlamouri+watch-blink_chromium.org, kozyatinskiy+blink_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Pause input events in WebFrameWidgetImpl while debugging. BUG=451004 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192269

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -16 lines) Patch
M Source/web/WebDevToolsAgentImpl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 7 chunks +54 lines, -16 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 6 chunks +21 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
5 years, 9 months ago (2015-03-20 16:21:00 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1021083003/diff/1/Source/web/WebDevToolsAgentImpl.cpp File Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/1021083003/diff/1/Source/web/WebDevToolsAgentImpl.cpp#newcode200 Source/web/WebDevToolsAgentImpl.cpp:200: // The view was not closed during the ...
5 years, 9 months ago (2015-03-20 16:52:10 UTC) #3
dgozman
https://codereview.chromium.org/1021083003/diff/1/Source/web/WebDevToolsAgentImpl.cpp File Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/1021083003/diff/1/Source/web/WebDevToolsAgentImpl.cpp#newcode200 Source/web/WebDevToolsAgentImpl.cpp:200: // The view was not closed during the dispatch. ...
5 years, 9 months ago (2015-03-20 16:58:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021083003/20001
5 years, 9 months ago (2015-03-20 16:58:39 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 18:25:12 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192269

Powered by Google App Engine
This is Rietveld 408576698