Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1021053005: Fix size calcuation in video_decoder_resource.cc (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
bbudge, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix size calcuation in video_decoder_resource.cc VideoDecoderResource::VideoDecoderResource() is only clearing 1/4 of the decode_ids_ array, because the type of the array is uint32_t, and we're passing the number of elements, not number of bytes. BUG=469182 Committed: https://crrev.com/e9faf30f4261a10fb0f964fa91d8822acebd53e0 Cr-Commit-Position: refs/heads/master@{#321698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/proxy/video_decoder_resource.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Tom Sepez
Bill, review as original author. piman for owners stamp.
5 years, 9 months ago (2015-03-20 22:28:08 UTC) #2
bbudge
Thanks! LGTM
5 years, 9 months ago (2015-03-20 22:31:17 UTC) #3
Tom Sepez
Actually, bbudge@ is an OWNER one directory up. Removing piman.
5 years, 9 months ago (2015-03-20 23:59:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021053005/1
5 years, 9 months ago (2015-03-21 00:02:07 UTC) #7
bbudge
On 2015/03/20 23:59:58, Tom Sepez wrote: > Actually, bbudge@ is an OWNER one directory up. ...
5 years, 9 months ago (2015-03-21 00:06:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-21 07:48:38 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e9faf30f4261a10fb0f964fa91d8822acebd53e0 Cr-Commit-Position: refs/heads/master@{#321698}
5 years, 9 months ago (2015-03-21 07:49:13 UTC) #10
piman
5 years, 9 months ago (2015-03-23 20:19:29 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698