content/common/child_process_messages.h - Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/child_process_messages.h

Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@phase_splitting

Patch Set: jar@ comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/child_thread_impl.cc ('K') | « content/child/child_thread_impl.cc ('k') | content/public/browser/profiler_controller.h » ('j') | content/public/browser/profiler_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/child_process_messages.h

diff --git a/content/common/child_process_messages.h b/content/common/child_process_messages.h

index 830cd62be0a3d48b16180cc70c050e764a7a62c5..7f1af44cade8b7e44d948f34ea0507df8867b495 100644

--- a/content/common/child_process_messages.h

+++ b/content/common/child_process_messages.h

@@ -103,8 +103,14 @@ IPC_MESSAGE_CONTROL1(ChildProcessMsg_SetProfilerStatus,

// Send to all the child processes to send back profiler data (ThreadData in

// tracked_objects).

-IPC_MESSAGE_CONTROL1(ChildProcessMsg_GetChildProfilerData,

- int /* sequence_number */)

+IPC_MESSAGE_CONTROL2(ChildProcessMsg_GetChildProfilerData,

+ int /* sequence_number */,

+ int /* current_profiling_phase */)

+// Send to all the child processes to send back profiler data (ThreadData in

+// tracked_objects).

Ilya Sherman 2015/04/07 01:15:31 Why is this comment the same as the one above? Ho

vadimt 2015/04/07 21:44:14 Done.

+IPC_MESSAGE_CONTROL1(ChildProcessMsg_OnProfilingPhase,

Ilya Sherman 2015/04/07 01:15:31 nit: "OnProfilingPhase" -> "ProfilingPhaseComplete

vadimt 2015/04/07 21:44:14 Done.

vadimt 2015/04/07 21:44:15 Done.

+ int /* profiling_phase */)

// Send to all the child processes to send back histogram data.

IPC_MESSAGE_CONTROL1(ChildProcessMsg_GetChildHistogramData,