components/metrics/profiler/tracking_synchronizer_observer.h - Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/profiler/tracking_synchronizer_observer.h

Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@phase_splitting

Patch Set: jar@ comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/metrics/profiler/tracking_synchronizer.cc ('K') | « components/metrics/profiler/tracking_synchronizer.cc ('k') | components/metrics/profiler/tracking_synchronizer_unittest.cc » ('j') | components/metrics/profiler/tracking_synchronizer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/profiler/tracking_synchronizer_observer.h

diff --git a/components/metrics/profiler/tracking_synchronizer_observer.h b/components/metrics/profiler/tracking_synchronizer_observer.h

index 0e943508079bd814169fae18b759ff563f74c21f..4ad62daff16172546bbe6f08e606dd20f2985d84 100644

--- a/components/metrics/profiler/tracking_synchronizer_observer.h

+++ b/components/metrics/profiler/tracking_synchronizer_observer.h

@@ -29,12 +29,6 @@ typedef std::vector<ProfilerEventProto::ProfilerEvent> ProfilerEvents;

// Observer for notifications from the TrackingSynchronizer class.

class TrackingSynchronizerObserver {

public:

- // TODO(vadimt): Consider isherman@ idea: I'd change the phase_start and

- // phase_finish from TimeDeltas to TimeTicks. And I'd omit the |past_events|

- // list -- either in favor of a single ProfilerEvent that corresponds to the

- // phase, or a method on the TrackingSynchronizer that can translate a

- // profiling_phase to a ProfilerEvent.

// Received |process_data_phase| for profiling phase |profiling_phase| from a

// single process of |process_type|. The phase start and finish times,

// relative to the start time are |phase_start| and