chrome/browser/metrics/first_web_contents_profiler.cc - Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/first_web_contents_profiler.cc

Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@phase_splitting

Patch Set: jar@ comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/tracked_objects.cc ('K') | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | components/metrics/profiler/tracking_synchronizer.h » ('j') | components/metrics/profiler/tracking_synchronizer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/first_web_contents_profiler.cc

diff --git a/chrome/browser/metrics/first_web_contents_profiler.cc b/chrome/browser/metrics/first_web_contents_profiler.cc

index ae97bac1bed4d80caea5663f85161163524bca7c..2ff223b7ddecc9b694203a6b561346fa6aec80b9 100644

--- a/chrome/browser/metrics/first_web_contents_profiler.cc

+++ b/chrome/browser/metrics/first_web_contents_profiler.cc

@@ -12,6 +12,8 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

+#include "components/metrics/metrics_log.h"

Ilya Sherman 2015/04/07 01:15:30 nit: This include seems wrong. If you just need t

vadimt 2015/04/07 21:44:14 Done.

+#include "components/metrics/profiler/tracking_synchronizer.h"

scoped_ptr<FirstWebContentsProfiler>

FirstWebContentsProfiler::CreateProfilerForFirstWebContents(

@@ -51,6 +53,9 @@ void FirstWebContentsProfiler::DidFirstVisuallyNonEmptyPaint() {

elapsed);

}

+ metrics::TrackingSynchronizer::OnProfilingPhaseCompletion(

+ metrics::ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT);

if (IsFinishedCollectingMetrics())

FinishedCollectingMetrics();

}