Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: components/metrics/profiler/tracking_synchronizer_unittest.cc

Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@phase_splitting
Patch Set: More asvitkine@ comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/profiler/tracking_synchronizer_unittest.cc
diff --git a/components/metrics/profiler/tracking_synchronizer_unittest.cc b/components/metrics/profiler/tracking_synchronizer_unittest.cc
index a597a477c64a0f5a8cdb6303bd24231149c8928a..23ca9fae671d97461898472f4fffbbf17de6a437 100644
--- a/components/metrics/profiler/tracking_synchronizer_unittest.cc
+++ b/components/metrics/profiler/tracking_synchronizer_unittest.cc
@@ -77,6 +77,27 @@ class TestObserver : public TrackingSynchronizerObserver {
DISALLOW_COPY_AND_ASSIGN(TestObserver);
};
+class TestTrackingSynchronizer : public TrackingSynchronizer {
+ public:
+ explicit TestTrackingSynchronizer(base::TimeTicks now)
+ : TrackingSynchronizer(now) {}
+
+ void RegisterPhaseCompletion(
+ ProfilerEventProto::ProfilerEvent profiling_event,
+ base::TimeTicks now) {
+ TrackingSynchronizer::RegisterPhaseCompletion(profiling_event, now);
+ }
+
+ ~TestTrackingSynchronizer() {}
+
+ void SendData(const tracked_objects::ProcessDataSnapshot& profiler_data,
+ content::ProcessType process_type,
+ base::TimeTicks now,
+ TrackingSynchronizerObserver* observer) const {
+ TrackingSynchronizer::SendData(profiler_data, process_type, now, observer);
+ }
+};
+
base::TimeTicks TestTimeFromMs(int64 ms) {
return base::TimeTicks() + base::TimeDelta::FromMilliseconds(ms);
}
@@ -88,13 +109,12 @@ TEST(TrackingSynchronizerTest, ProfilerData) {
#if !defined(OS_IOS)
content::TestBrowserThreadBundle thread_bundle;
#endif
- scoped_refptr<TrackingSynchronizer> tracking_synchronizer =
- new TrackingSynchronizer(TestTimeFromMs(111));
- // Mimic a phase change event.
- tracking_synchronizer->phase_completion_events_sequence_.push_back(
- ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT);
- tracking_synchronizer->phase_start_times_.push_back(TestTimeFromMs(333));
+ scoped_refptr<TestTrackingSynchronizer> tracking_synchronizer =
+ new TestTrackingSynchronizer(TestTimeFromMs(111));
+
+ tracking_synchronizer->RegisterPhaseCompletion(
+ ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT, TestTimeFromMs(333));
tracked_objects::ProcessDataSnapshot profiler_data;
ProcessDataPhaseSnapshot snapshot0;

Powered by Google App Engine
This is Rietveld 408576698