Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6418)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@phase_splitting
Patch Set: More comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 031a591ca8d9b3a143d4fd2c0c95066447043bbb..72188ed10aaffe6692f2fe7b0fbd20c7ddbf0d4e 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -133,6 +133,7 @@ ChromeMetricsServiceClient::ChromeMetricsServiceClient(
google_update_metrics_provider_(nullptr),
#endif
drive_metrics_provider_(nullptr),
+ start_time_(base::TimeTicks::Now()),
weak_ptr_factory_(this) {
DCHECK(thread_checker_.CalledOnValidThread());
RecordCommandLineMetrics();
@@ -423,19 +424,14 @@ void ChromeMetricsServiceClient::OnInitTaskGotGoogleUpdateData() {
weak_ptr_factory_.GetWeakPtr());
}
-// TODO(vadimt): Consider wrapping params in a struct after the list of params
-// to ReceivedProfilerData settles. crbug/456354.
void ChromeMetricsServiceClient::ReceivedProfilerData(
+ const metrics::ProfilerDataAttributes& attributes,
const tracked_objects::ProcessDataPhaseSnapshot& process_data_phase,
- base::ProcessId process_id,
- content::ProcessType process_type,
- int profiling_phase,
- base::TimeDelta phase_start,
- base::TimeDelta phase_finish,
const metrics::ProfilerEvents& past_events) {
profiler_metrics_provider_->RecordProfilerData(
- process_data_phase, process_id, process_type, profiling_phase,
- phase_start, phase_finish, past_events);
+ process_data_phase, attributes.process_id, attributes.process_type,
+ attributes.profiling_phase, attributes.phase_start - start_time_,
+ attributes.phase_finish - start_time_, past_events);
}
void ChromeMetricsServiceClient::FinishedReceivingProfilerData() {

Powered by Google App Engine
This is Rietveld 408576698