chrome/browser/metrics/chrome_metrics_service_client.h - Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@phase_splitting

Patch Set: Continuation of dialogue with asvitkine@. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/tracked_objects.cc ('K') | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | components/metrics/profiler/tracking_synchronizer_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.h

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h

index 7456d1dc15065b07d4d2322ff0671c26a8eeb1fc..d1b6c76a78706c66d125d02f71a902498e46ae93 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.h

+++ b/chrome/browser/metrics/chrome_metrics_service_client.h

@@ -101,8 +101,8 @@ class ChromeMetricsServiceClient

base::ProcessId process_id,

content::ProcessType process_type,

int profiling_phase,

- base::TimeDelta phase_start,

- base::TimeDelta phase_finish,

+ base::TimeTicks phase_start,

+ base::TimeTicks phase_finish,

const metrics::ProfilerEvents& past_profiler_events) override;

void FinishedReceivingProfilerData() override;

@@ -185,6 +185,9 @@ class ChromeMetricsServiceClient

// used.

base::Callback<void(bool*)> cellular_callback_;

+ // Time of this object's creation.

+ const base::TimeTicks start_time_;

base::WeakPtrFactory<ChromeMetricsServiceClient> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServiceClient);