Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

chrome/browser/metrics/chrome_metrics_service_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 115 matching lines @@
       waiting_for_collect_final_metrics_step_(false),
       num_async_histogram_fetches_in_progress_(0),
       profiler_metrics_provider_(nullptr),
 #if defined(ENABLE_PLUGINS)
       plugin_metrics_provider_(nullptr),
 #endif
 #if defined(OS_WIN)
       google_update_metrics_provider_(nullptr),
 #endif
       drive_metrics_provider_(nullptr),
+      start_time_(base::TimeTicks::Now()),
       weak_ptr_factory_(this) {
   DCHECK(thread_checker_.CalledOnValidThread());
   RecordCommandLineMetrics();
   RegisterForNotifications();
 }
 
 ChromeMetricsServiceClient::~ChromeMetricsServiceClient() {
   DCHECK(thread_checker_.CalledOnValidThread());
 }
 
@@ skipping 270 matching lines @@
 #endif  // defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD)
 }
 
 void ChromeMetricsServiceClient::OnInitTaskGotGoogleUpdateData() {
   // Start the next part of the init task: fetching performance data.  This will
   // call into |FinishedReceivingProfilerData()| when the task completes.
   metrics::TrackingSynchronizer::FetchProfilerDataAsynchronously(
       weak_ptr_factory_.GetWeakPtr());
 }
 
-// TODO(vadimt): Consider wrapping params in a struct after the list of params
-// to ReceivedProfilerData settles. crbug/456354.
 void ChromeMetricsServiceClient::ReceivedProfilerData(
+    const metrics::ProfilerDataAttributes& attributes,
     const tracked_objects::ProcessDataPhaseSnapshot& process_data_phase,
-    base::ProcessId process_id,
-    content::ProcessType process_type,
-    int profiling_phase,
-    base::TimeDelta phase_start,
-    base::TimeDelta phase_finish,
     const metrics::ProfilerEvents& past_events) {
   profiler_metrics_provider_->RecordProfilerData(
-      process_data_phase, process_id, process_type, profiling_phase,
-      phase_start, phase_finish, past_events);
+      process_data_phase, attributes.process_id, attributes.process_type,
+      attributes.profiling_phase, attributes.phase_start - start_time_,
+      attributes.phase_finish - start_time_, past_events);
 }
 
 void ChromeMetricsServiceClient::FinishedReceivingProfilerData() {
   drive_metrics_provider_->GetDriveMetrics(
       finished_gathering_initial_metrics_callback_);
 }
 
 void ChromeMetricsServiceClient::OnMemoryDetailCollectionDone() {
   DCHECK(thread_checker_.CalledOnValidThread());
 
@@ skipping 108 matching lines @@
     case content::NOTIFICATION_LOAD_START:
     case content::NOTIFICATION_RENDERER_PROCESS_CLOSED:
     case content::NOTIFICATION_RENDER_WIDGET_HOST_HANG:
       metrics_service_->OnApplicationNotIdle();
       break;
 
     default:
       NOTREACHED();
   }
 }