Issue 1021043002: Make WDDestroyableResult<T> derive from WDResult<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1021043002: Make WDDestroyableResult<T> derive from WDResult<T>. (Closed)

Created:
5 years, 9 months ago by pcc1

Modified:
5 years, 9 months ago

Reviewers:
pcc, Cait (Slow)

CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make WDDestroyableResult<T> derive from WDResult<T>. This fixes an issue found by -fsanitize=cfi-derived-cast caused by code that casts a WDResult<T> pointer to WDDestroyableResult<T>. BUG=457523 R=caitkp@chromium.org Committed: https://crrev.com/d317e89dc1ae054c4d5e1672ebde8ed0ad3d8899 Cr-Commit-Position: refs/heads/master@{#321644}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	components/webdata/common/web_data_results.h	View		2 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cait (Slow)

LGTM Just curious: can you point me to the code that's doing this cast? Thanks!

5 years, 9 months ago (2015-03-20 15:04:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021043002/1

5 years, 9 months ago (2015-03-20 20:21:18 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-20 22:01:41 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d317e89dc1ae054c4d5e1672ebde8ed0ad3d8899
Cr-Commit-Position: refs/heads/master@{#321644}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages