Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1021033002: Some usability ideas around SkTHash. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Some usability ideas around SkTHash. - By default, use new SkGoodHash to hash keys, which is: * for 4 byte values, use SkChecksum::Mix, * for SkStrings, use SkChecksum::Murmur3 on the data, * for other structs, shallow hash the struct with Murmur3. - Expand SkChecksum::Murmur3 to support non-4-byte-aligned data. - Add const foreach() methods. - Have foreach() take a functor, which allows lambdas. BUG=skia: Committed: https://skia.googlesource.com/skia/+/02f46cf878535fb79317d15ebed66dfa3f2cd772

Patch Set 1 #

Patch Set 2 : comment, simplify tests #

Patch Set 3 : minor tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -43 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M src/core/SkChecksum.h View 1 2 4 chunks +37 lines, -7 lines 0 comments Download
M src/core/SkTHash.h View 1 2 4 chunks +26 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/svg/SkSVGDevice.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M tests/ChecksumTest.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/HashTest.cpp View 1 3 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mtklein_C
5 years, 9 months ago (2015-03-20 01:20:31 UTC) #2
f(malita)
lgtm!
5 years, 9 months ago (2015-03-20 13:37:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021033002/40001
5 years, 9 months ago (2015-03-20 20:38:59 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 20:48:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/02f46cf878535fb79317d15ebed66dfa3f2cd772

Powered by Google App Engine
This is Rietveld 408576698