Roll Breakpad r1234:r1240.

Roll Breakpad r1234:r1240.

r1240: Add missing #include of eintr_wrapper.h to auto_testfile.h.
r1239: Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.
r1238: Re-enable ios_exception_minidump_generator being built on non-ARM.
r1237: Fix BREAKPAD_OUTPUT_DUMP_FILE on iOS.
r1236: Process minidumps generated on ARM64 in iOS apps.
r1235: Generate minidumps for 64-bit ARM apps on iOS.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238524

[blundell, 2013-12-03 17:45:35]

I did simple regression testing on Chrome for iOS and Chromium for Mac via
chrome://inducebrowsercrashforrealz. I was never able to generate the dSYM on
the Mac, but the trace is the right one (generating symbols from the debug
libraries, which results in mangled names).

I will be watching canaries for the next couple of days after this lands to look
for regressions.

[Mark Mentovai, 2013-12-03 17:49:05]

LGTM. Either commit by the commit queue or make sure the try bots can at least
compile it before committing manually.

[commit-bot: I haz the power, 2013-12-03 17:51:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/102103003/1

[commit-bot: I haz the power, 2013-12-03 18:24:35]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[blundell, 2013-12-03 18:38:36]

On 2013/12/03 18:24:35, I haz the power (commit-bot) wrote:
> Retried try job too often on android_clang_dbg for step(s) slave_steps
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

Mark, it looks like this is r1239. Should I roll up to r1238 for now?

[Mark Mentovai, 2013-12-03 18:46:45]

Give me a minute, I’ll get you a r1230 that fixes this.


On Tue, Dec 3, 2013 at 1:38 PM, <blundell@chromium.org> wrote:

> On 2013/12/03 18:24:35, I haz the power (commit-bot) wrote:
>
>> Retried try job too often on android_clang_dbg for step(s) slave_steps
>>
>
> http://build.chromium.org/p/tryserver.chromium/
> buildstatus?builder=android_clang_dbg&number=97486
>
> Mark, it looks like this is r1239. Should I roll up to r1238 for now?
>
> https://codereview.chromium.org/102103003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark Mentovai, 2013-12-03 18:58:37]

https://breakpad.appspot.com/804002/


On Tue, Dec 3, 2013 at 1:46 PM, Mark Mentovai <mark@chromium.org> wrote:

> Give me a minute, I’ll get you a r1230 that fixes this.
>
>
> On Tue, Dec 3, 2013 at 1:38 PM, <blundell@chromium.org> wrote:
>
>> On 2013/12/03 18:24:35, I haz the power (commit-bot) wrote:
>>
>>> Retried try job too often on android_clang_dbg for step(s) slave_steps
>>>
>>
>> http://build.chromium.org/p/tryserver.chromium/
>> buildstatus?builder=android_clang_dbg&number=97486
>>
>> Mark, it looks like this is r1239. Should I roll up to r1238 for now?
>>
>> https://codereview.chromium.org/102103003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark Mentovai, 2013-12-03 19:02:05]

LGTM again with the DEPS file changed to 1240, and the CL description changed
appropriately.

If that doesn’t work, LGTM with 1238, and I’ll deal with the rest.

[commit-bot: I haz the power, 2013-12-03 20:26:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/102103003/20001

[commit-bot: I haz the power, 2013-12-04 00:04:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/102103003/20001

[commit-bot: I haz the power, 2013-12-04 01:54:55]

Change committed as 238524