Source/core/xml/XMLHttpRequest.h - Issue 102103002: Have HashMap<KeyType, AtomicString>::get() return a const reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XMLHttpRequest.h

Issue 102103002: Have HashMap<KeyType, AtomicString>::get() return a const reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString::ConstructFromLiteral Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XMLHttpRequest.h

diff --git a/Source/core/xml/XMLHttpRequest.h b/Source/core/xml/XMLHttpRequest.h

index df7fdd739a7ae6763767badc80646cf61e7bbb57..d38e2c25c231a05d7f632793bb40307dcce1e5ab 100644

--- a/Source/core/xml/XMLHttpRequest.h

+++ b/Source/core/xml/XMLHttpRequest.h

@@ -113,7 +113,7 @@ public:

void setRequestHeader(const AtomicString& name, const AtomicString& value, ExceptionState&);

void overrideMimeType(const AtomicString& override);

String getAllResponseHeaders(ExceptionState&) const;

- AtomicString getResponseHeader(const AtomicString& name, ExceptionState&) const;

+ const AtomicString& getResponseHeader(const AtomicString& name, ExceptionState&) const;

ScriptString responseText(ExceptionState&);

ScriptString responseJSONSource();

Document* responseXML(ExceptionState&);

@@ -167,7 +167,7 @@ private:

bool initSend(ExceptionState&);

void sendBytesData(const void*, size_t, ExceptionState&);

- AtomicString getRequestHeader(const AtomicString& name) const;

+ const AtomicString& getRequestHeader(const AtomicString& name) const;

void setRequestHeaderInternal(const AtomicString& name, const AtomicString& value);

void trackProgress(int dataLength);

« no previous file with comments | « Source/core/timing/Performance.cpp ('k') | Source/core/xml/XMLHttpRequest.cpp » ('j') | no next file with comments »