Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: Source/core/xml/XMLHttpRequest.cpp

Issue 102103002: Have HashMap<KeyType, AtomicString>::get() return a const reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/xml/XMLHttpRequest.cpp
diff --git a/Source/core/xml/XMLHttpRequest.cpp b/Source/core/xml/XMLHttpRequest.cpp
index dc6d85947c97ebbf57cb8fd5ca7261bd4ee50da6..a70debb5f2fa11caccb0ad70cc131aa1e91c7ee4 100644
--- a/Source/core/xml/XMLHttpRequest.cpp
+++ b/Source/core/xml/XMLHttpRequest.cpp
@@ -625,8 +625,7 @@ void XMLHttpRequest::send(Document* document, ExceptionState& exceptionState)
return;
if (areMethodAndURLValidForSend()) {
- String contentType = getRequestHeader("Content-Type");
- if (contentType.isEmpty()) {
+ if (getRequestHeader("Content-Type").isEmpty()) {
// FIXME: this should include the charset used for encoding.
setRequestHeaderInternal("Content-Type", "application/xml");
}
@@ -676,8 +675,7 @@ void XMLHttpRequest::send(Blob* body, ExceptionState& exceptionState)
return;
if (areMethodAndURLValidForSend()) {
- const String& contentType = getRequestHeader("Content-Type");
- if (contentType.isEmpty()) {
+ if (getRequestHeader("Content-Type").isEmpty()) {
const String& blobType = body->type();
if (!blobType.isEmpty() && isValidContentType(blobType))
setRequestHeaderInternal("Content-Type", AtomicString(blobType));
@@ -1085,7 +1083,7 @@ void XMLHttpRequest::setRequestHeaderInternal(const AtomicString& name, const At
result.iterator->value = result.iterator->value + ", " + value;
}
-AtomicString XMLHttpRequest::getRequestHeader(const AtomicString& name) const
+const AtomicString& XMLHttpRequest::getRequestHeader(const AtomicString& name) const
{
return m_requestHeaders.get(name);
}
@@ -1124,7 +1122,7 @@ String XMLHttpRequest::getAllResponseHeaders(ExceptionState& exceptionState) con
return stringBuilder.toString();
}
-AtomicString XMLHttpRequest::getResponseHeader(const AtomicString& name, ExceptionState& exceptionState) const
+const AtomicString& XMLHttpRequest::getResponseHeader(const AtomicString& name, ExceptionState& exceptionState) const
{
if (m_state < HEADERS_RECEIVED || m_error)
return nullAtom;

Powered by Google App Engine
This is Rietveld 408576698