chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc - Issue 10210009: sync: Loop committing items without downloading updates (v2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

Issue 10210009: sync: Loop committing items without downloading updates (v2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactor loop again, add comments + more Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc ('k') | chrome/browser/sync/test_profile_sync_service.cc » ('j') | sync/engine/commit.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc b/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

index ba4ead50db1fabff1d5fe3740622edfbfa3d71ac..0bebb5d760eb44612ef55c58304acc473e9330b4 100644

--- a/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

+++ b/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

@@ -1915,7 +1915,6 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,

RestartSyncService(0);

ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion("Restarted sync."));

ASSERT_TRUE(AllModelsMatchVerifier());

- ASSERT_EQ(0, GetClient(0)->GetStatus().unsynced_count);

}

// Trigger the server side creation of Synced Bookmarks. Ensure both clients