Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1020993002: cc: Do not pass BeginFrameArgs to state machine. (Closed)

Created:
5 years, 9 months ago by sunnyps
Modified:
5 years, 9 months ago
Reviewers:
brianderson, mithro-old
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Do not pass BeginFrameArgs to state machine. The scheduler state machine should not rely on BeginFrameArgs for any decision. The state machine is the "digital" part of the system while the scheduler is the "analog" part of the system. BUG=439275 Committed: https://crrev.com/bd2c8968d05dacc4f159682e36f33e4aa487bdf1 Cr-Commit-Position: refs/heads/master@{#321476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -104 lines) Patch
M cc/scheduler/scheduler.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 4 chunks +2 lines, -6 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 3 chunks +4 lines, -30 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 59 chunks +62 lines, -66 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sunnyps
PTAL This was split out of my webview CL
5 years, 9 months ago (2015-03-19 22:08:06 UTC) #2
brianderson
lgtm Yay for patches that remove more lines than they add.
5 years, 9 months ago (2015-03-19 23:09:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020993002/1
5 years, 9 months ago (2015-03-19 23:14:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 00:13:19 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 00:14:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd2c8968d05dacc4f159682e36f33e4aa487bdf1
Cr-Commit-Position: refs/heads/master@{#321476}

Powered by Google App Engine
This is Rietveld 408576698