Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 1020973003: Make git cl try work in light of the new CQ config.json format (Closed)

Created:
5 years, 9 months ago by smut
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make git cl try work in light of the new CQ config.json format BUG=468841 TBR=jochen@chromium.org TESTED=All try jobs for this CL were triggered using a no-argument "git cl try". Committed: https://crrev.com/3ef206e1494c1cd0fc16c0ff71b5c2d1dc2bb54c Cr-Commit-Position: refs/heads/master@{#321537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M PRESUBMIT.py View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
smut
This should get "git cl try" working, but in the long-term, maybe someone should better ...
5 years, 9 months ago (2015-03-19 23:37:13 UTC) #2
Nico
Looks fine to me (thanks!), but sergiyb should probably do the official review.
5 years, 9 months ago (2015-03-19 23:48:06 UTC) #3
smut
On 2015/03/19 23:48:06, Nico (traveling) wrote: > Looks fine to me (thanks!), but sergiyb should ...
5 years, 9 months ago (2015-03-19 23:49:16 UTC) #4
Nico
You can land it TBR=sergiyb. (Normally I'd say revert the offending change, but it looks ...
5 years, 9 months ago (2015-03-19 23:57:11 UTC) #5
smut
On 2015/03/19 23:57:11, Nico (traveling) wrote: > You can land it TBR=sergiyb. > > (Normally ...
5 years, 9 months ago (2015-03-20 00:15:34 UTC) #6
Sergiy Byelozyorov
lgtm
5 years, 9 months ago (2015-03-20 09:08:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020973003/1
5 years, 9 months ago (2015-03-20 09:12:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51002)
5 years, 9 months ago (2015-03-20 09:18:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020973003/1
5 years, 9 months ago (2015-03-20 09:26:22 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 09:30:10 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3ef206e1494c1cd0fc16c0ff71b5c2d1dc2bb54c Cr-Commit-Position: refs/heads/master@{#321537}
5 years, 9 months ago (2015-03-20 09:30:47 UTC) #16
sdefresne
5 years, 9 months ago (2015-03-20 09:51:30 UTC) #17
Message was sent while issue was closed.
jochen: TBR-ed for OWNERS of PRESUBMIT.py since it was marked as P0 and thakis
said that we could TBR this CL

Powered by Google App Engine
This is Rietveld 408576698