Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 1020923002: Remove dubious part from fast/block/margin-collapse/self-collapsing-cols-creates-block-formatting-c… (Closed)

Created:
5 years, 9 months ago by mstensho (USE GERRIT)
Modified:
5 years, 9 months ago
Reviewers:
rune
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove dubious part from fast/block/margin-collapse/self-collapsing-cols-creates-block-formatting-context.html The test had invalid column-span:all elements, i.e. there was no multicol containing block. The new multicol implementation ignores all effects of column-span:all unless it's a valid one, while the old / current implementation doesn't. BUG=386567 R=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M LayoutTests/fast/block/margin-collapse/self-collapsing-cols-creates-block-formatting-context.html View 3 chunks +2 lines, -14 lines 0 comments Download
M LayoutTests/fast/block/margin-collapse/self-collapsing-cols-creates-block-formatting-context-expected.html View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 9 months ago (2015-03-19 19:09:08 UTC) #1
rune
lgtm
5 years, 9 months ago (2015-03-20 09:22:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020923002/1
5 years, 9 months ago (2015-03-20 10:23:37 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 10:27:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192236

Powered by Google App Engine
This is Rietveld 408576698