Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1020873002: [turbofan] Fix GVN of projections and add verification for projection uniqueness. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix GVN of projections and add verification for projection uniqueness. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/de2a225a823905648d8e10dcfa3b51d3148fddd2 Cr-Commit-Position: refs/heads/master@{#27304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M src/compiler/common-operator.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 9 months ago (2015-03-19 12:38:42 UTC) #1
Benedikt Meurer
Urghs. lgtm
5 years, 9 months ago (2015-03-19 12:41:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020873002/1
5 years, 9 months ago (2015-03-19 12:43:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:03:57 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:04:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de2a225a823905648d8e10dcfa3b51d3148fddd2
Cr-Commit-Position: refs/heads/master@{#27304}

Powered by Google App Engine
This is Rietveld 408576698