Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: content/common/sandbox_win.cc

Issue 1020863012: To narrow down LowBox/AppContainer launch issue reporting UMA on specific create process error code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index 8849a86ae900b7eb4ae4f9a59cb6e29cbf0e1150..7749d7bd84ec34591edb4d02a71fc20b449f9b85 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -736,15 +736,17 @@ base::Process StartSandboxedProcess(
if (sandbox::SBOX_ALL_OK != result) {
if (result == sandbox::SBOX_ERROR_GENERIC)
DPLOG(ERROR) << "Failed to launch process";
- else
+ else if (result == sandbox::SBOX_ERROR_CREATE_PROCESS) {
+ // TODO(shrikant): Remove this special case handling after determining
+ // cause for lowbox/createprocess errors.
+ sandbox::PolicyBase* policy_base =
+ static_cast<sandbox::PolicyBase*>(policy);
+ if (policy_base->GetLowBoxSid()) {
+ UMA_HISTOGRAM_SPARSE_SLOWLY("Process.Sandbox.Lowbox.Launch.Error",
+ last_error);
+ }
+ } else
DLOG(ERROR) << "Failed to launch process. Error: " << result;
-
- sandbox::PolicyBase* policy_base =
- static_cast<sandbox::PolicyBase*>(policy);
- if (policy_base->GetLowBoxSid()) {
- UMA_HISTOGRAM_SPARSE_SLOWLY("Process.Sandbox.Lowbox.Launch.Error",
- last_error);
- }
return base::Process();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698