DescriptionRevert of Add ClientConfig proto, and JSON generation/parsing. (patchset #6 id:100001 of https://codereview.chromium.org/1017853003/)
Reason for revert:
Seems that some of the tests introduced in this CL are failing on builders:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/11450/steps/components_unittests/logs/stdio
Value of: config_parser::TimeToISO8601(test.time)
Actual: "2009-04-22T19:24:48.000Z"
Expected: test.expected
Which is: "1601-01-01T00:00:00.000Z"
[ FAILED ] ClientConfigParserTest.TimeToISO8601 (0 ms)
Value of: config_parser::TimestampToTime(ts)
Actual: 1964-11-24 17:31:43.000 UTC
Expected: test.expected_time
Which is: 2038-01-19 03:14:07.999 UTC
[ FAILED ] ClientConfigParserTest.TimestampToTime (0 ms)
No idea why they are failing there, or why they passed on the trybots.
Original issue's description:
> Add ClientConfig proto, and JSON generation/parsing.
>
> - Add the ClientConfig proto definition corresponding to the response
> coming from the service.
> - Create a means of generating a pseudo response from the built in
> params and request options.
> - Create a class to parse the JSON response.
> - Add necessary helper classes for the ProxyScheme and time values
> coming from the service.
>
> BUG=466753
>
> Committed: https://crrev.com/97652ebe50c4be712aa976776bee9694cbce1178
> Cr-Commit-Position: refs/heads/master@{#321931}
TBR=bengr@chromium.org,sclittle@chromium.org,jeremyim@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466753
Committed: https://crrev.com/b16d99f9e5a9f46a62b8fc62662a4f6cd23cff17
Cr-Commit-Position: refs/heads/master@{#321936}
Patch Set 1 #
Created: 5 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|