Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1020863009: Revert of Add ClientConfig proto, and JSON generation/parsing. (Closed)

Created:
5 years, 9 months ago by Matt Giuca
Modified:
5 years, 9 months ago
Reviewers:
jeremyim, bengr, sclittle
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ClientConfig proto, and JSON generation/parsing. (patchset #6 id:100001 of https://codereview.chromium.org/1017853003/) Reason for revert: Seems that some of the tests introduced in this CL are failing on builders: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/11450/steps/components_unittests/logs/stdio Value of: config_parser::TimeToISO8601(test.time) Actual: "2009-04-22T19:24:48.000Z" Expected: test.expected Which is: "1601-01-01T00:00:00.000Z" [ FAILED ] ClientConfigParserTest.TimeToISO8601 (0 ms) Value of: config_parser::TimestampToTime(ts) Actual: 1964-11-24 17:31:43.000 UTC Expected: test.expected_time Which is: 2038-01-19 03:14:07.999 UTC [ FAILED ] ClientConfigParserTest.TimestampToTime (0 ms) No idea why they are failing there, or why they passed on the trybots. Original issue's description: > Add ClientConfig proto, and JSON generation/parsing. > > - Add the ClientConfig proto definition corresponding to the response > coming from the service. > - Create a means of generating a pseudo response from the built in > params and request options. > - Create a class to parse the JSON response. > - Add necessary helper classes for the ProxyScheme and time values > coming from the service. > > BUG=466753 > > Committed: https://crrev.com/97652ebe50c4be712aa976776bee9694cbce1178 > Cr-Commit-Position: refs/heads/master@{#321931} TBR=bengr@chromium.org,sclittle@chromium.org,jeremyim@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466753 Committed: https://crrev.com/b16d99f9e5a9f46a62b8fc62662a4f6cd23cff17 Cr-Commit-Position: refs/heads/master@{#321936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1034 lines) Patch
M components/components_tests.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M components/data_reduction_proxy.gypi View 5 chunks +0 lines, -24 lines 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 4 chunks +0 lines, -5 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h View 1 chunk +0 lines, -48 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h View 6 chunks +4 lines, -25 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc View 7 chunks +7 lines, -47 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc View 3 chunks +36 lines, -60 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h View 7 chunks +1 line, -55 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc View 5 chunks +2 lines, -71 lines 0 comments Download
M components/data_reduction_proxy/core/common/BUILD.gn View 4 chunks +0 lines, -5 lines 0 comments Download
D components/data_reduction_proxy/core/common/data_reduction_proxy_client_config_parser.h View 1 chunk +0 lines, -51 lines 0 comments Download
D components/data_reduction_proxy/core/common/data_reduction_proxy_client_config_parser.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D components/data_reduction_proxy/core/common/data_reduction_proxy_client_config_parser_unittest.cc View 1 chunk +0 lines, -228 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 3 chunks +0 lines, -43 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc View 2 chunks +0 lines, -27 lines 0 comments Download
D components/data_reduction_proxy/proto/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/data_reduction_proxy/proto/client_config.proto View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Giuca
Created Revert of Add ClientConfig proto, and JSON generation/parsing.
5 years, 9 months ago (2015-03-24 05:14:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020863009/1
5 years, 9 months ago (2015-03-24 05:14:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 05:15:29 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 05:16:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b16d99f9e5a9f46a62b8fc62662a4f6cd23cff17
Cr-Commit-Position: refs/heads/master@{#321936}

Powered by Google App Engine
This is Rietveld 408576698