Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1020863007: Revert of Change default code flag to NewAvatarMenu. (Closed)

Created:
5 years, 9 months ago by Mike Lerman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, Jay Civelli
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change default code flag to NewAvatarMenu. (patchset #29 id:580001 of https://codereview.chromium.org/845373002/) Reason for revert: Broke Linux Valgrind tests on the waterfall. I'll need to do more testing / work on this CL before it's ready to land. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%285%29/builds/34330 Original issue's description: > Change default code flag to NewAvatarMenu. Flags or Finch Configs still take priority, but all else being equal we should direct the user to NewAvatarMenu. > > This CL fixes a few issues that arise when the flag's on: > - Missing alt text on chrome://settings > - Unit tests for old components (OldAvatarMenu) need to force that state > - The ProfileAvatarDownloader works automatically with NewAvatarMenu on - this needs to be accounted for so it doesn't leave images hanging around. > - BookmarkBubbleSigninDelegate now triggers the User Menu, not a Sign in tab, on Desktop. (note this can't be easily tested in Cocoa) > > BUG=287883 > > Committed: https://crrev.com/e4d285b050ab3429f7d937fde6234fcba07a360e > Cr-Commit-Position: refs/heads/master@{#321770} TBR=rogerta@chromium.org,shess@chromium.org,dbeam@chromium.org,noms@chromium.org,sky@chromium.org,mukai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=287883 Committed: https://crrev.com/f7f718b5c5927f20d1744fd0917c702f4e0c9328 Cr-Commit-Position: refs/heads/master@{#321789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -293 lines) Patch
M chrome/browser/notifications/message_center_settings_controller_unittest.cc View 1 chunk +1 line, -12 lines 0 comments Download
M chrome/browser/profiles/profile_avatar_downloader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_avatar_downloader.cc View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 4 chunks +17 lines, -38 lines 0 comments Download
M chrome/browser/profiles/profile_info_interface.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options_profile_list.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 2 chunks +0 lines, -13 lines 0 comments Download
A chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc View 1 chunk +124 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller_unittest.mm View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm View 4 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm View 5 chunks +9 lines, -11 lines 0 comments Download
D chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc View 1 chunk +0 lines, -147 lines 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button_browsertest.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Lerman
Created Revert of Change default code flag to NewAvatarMenu.
5 years, 9 months ago (2015-03-23 16:27:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020863007/1
5 years, 9 months ago (2015-03-23 16:27:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 16:28:36 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 16:29:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7f718b5c5927f20d1744fd0917c702f4e0c9328
Cr-Commit-Position: refs/heads/master@{#321789}

Powered by Google App Engine
This is Rietveld 408576698