Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1020853022: Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer. (Closed)

Created:
5 years, 9 months ago by Igor Sheludko
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer. BUG=chromium:470801 LOG=Y Committed: https://crrev.com/2f3a42f9a1d66ffc9d260d9700ff831c3aa1cd41 Cr-Commit-Position: refs/heads/master@{#27467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/heap/mark-compact.cc View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Igor Sheludko
PTAL
5 years, 9 months ago (2015-03-26 08:44:21 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-26 08:52:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020853022/1
5 years, 9 months ago (2015-03-26 08:52:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 09:00:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2f3a42f9a1d66ffc9d260d9700ff831c3aa1cd41 Cr-Commit-Position: refs/heads/master@{#27467}
5 years, 9 months ago (2015-03-26 09:00:33 UTC) #7
Igor Sheludko
5 years, 9 months ago (2015-03-27 06:34:16 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1033163002/ by ishell@chromium.org.

The reason for reverting is: Reverting risky GC changes that block v8 roll..

Powered by Google App Engine
This is Rietveld 408576698