Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1020853013: V8 Sampling profiler: Introduce PlatformData (Closed)

Created:
5 years, 9 months ago by alph
Modified:
5 years, 9 months ago
Reviewers:
yurys
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V8 Sampling profiler: Introduce PlatformData Make profiler less dependent on src/base BUG=406277 Committed: https://crrev.com/6e747269c67a44bf09258e0afc116f6307879180 Cr-Commit-Position: refs/heads/master@{#322140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -29 lines) Patch
M content/renderer/devtools/v8_sampling_profiler.cc View 8 chunks +61 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alph
5 years, 9 months ago (2015-03-25 09:13:41 UTC) #2
yurys
lgtm
5 years, 9 months ago (2015-03-25 09:49:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020853013/1
5 years, 9 months ago (2015-03-25 09:50:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 11:52:28 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 11:53:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e747269c67a44bf09258e0afc116f6307879180
Cr-Commit-Position: refs/heads/master@{#322140}

Powered by Google App Engine
This is Rietveld 408576698