Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1020853012: [Icons NTP] Add window.configData.useIcons. (Closed)

Created:
5 years, 9 months ago by huangs
Modified:
5 years, 9 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Icons NTP] Add window.configData.useIcons. This propagates the presence of IconNTP/Enabled to the local NTP, so we keep display old design and conditionally render (upcoming) new design. BUG=467712 Committed: https://crrev.com/c09e0886e23d8af8a9ece8954aa395d119a847d1 Cr-Commit-Position: refs/heads/master@{#322161}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix spacing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/search/local_ntp_source.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
huangs
PTAL.
5 years, 9 months ago (2015-03-24 20:20:18 UTC) #2
Mathieu
lgtm with nit https://codereview.chromium.org/1020853012/diff/1/chrome/browser/search/local_ntp_source.cc File chrome/browser/search/local_ntp_source.cc (right): https://codereview.chromium.org/1020853012/diff/1/chrome/browser/search/local_ntp_source.cc#newcode86 chrome/browser/search/local_ntp_source.cc:86: } missing newline
5 years, 9 months ago (2015-03-25 13:36:39 UTC) #3
huangs
Thanks. Committing! https://codereview.chromium.org/1020853012/diff/1/chrome/browser/search/local_ntp_source.cc File chrome/browser/search/local_ntp_source.cc (right): https://codereview.chromium.org/1020853012/diff/1/chrome/browser/search/local_ntp_source.cc#newcode86 chrome/browser/search/local_ntp_source.cc:86: } On 2015/03/25 13:36:39, Mathieu Perreault wrote: ...
5 years, 9 months ago (2015-03-25 14:10:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020853012/20001
5 years, 9 months ago (2015-03-25 14:11:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 15:01:08 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 15:01:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c09e0886e23d8af8a9ece8954aa395d119a847d1
Cr-Commit-Position: refs/heads/master@{#322161}

Powered by Google App Engine
This is Rietveld 408576698