pkg/compiler/lib/src/inferrer/type_graph_nodes.dart - Issue 1020853007: Don't bailout of type inference for simple NSM implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

Issue 1020853007: Don't bailout of type inference for simple NSM implementations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: unnecessary blank line Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/inferrer/node_tracer.dart ('k') | pkg/compiler/lib/src/types/flat_type_mask.dart » ('j') | tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

diff --git a/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart b/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

index 7b673d028cdb8f6ab340e9e680cdda66cf7350a4..afb145b9062b8ce869d97e868e5a7c58ec0fa8df 100644

--- a/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

+++ b/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

@@ -760,11 +760,12 @@ class DynamicCallSiteTypeInformation extends CallSiteTypeInformation {

}

- bool get targetsIncludeNoSuchMethod {

+ bool targetsIncludeComplexNoSuchMethod(TypeGraphInferrerEngine inferrer) {

return targets.any((Element e) {

return e is FunctionElement &&

e.isInstanceMember &&

- e.name == Compiler.NO_SUCH_METHOD;

+ e.name == Compiler.NO_SUCH_METHOD &&

+ inferrer.backend.noSuchMethodRegistry.otherImpls.contains(e);

floitsch 2015/03/23 21:02:27 Don't just reach into the nsm-registry. Make a met

Harry Terkelsen 2015/03/23 22:31:18 Done.

});

}