Remove duplicate Enum Font Pitch

Remove duplicate Enum Font Pitch

Remove Pitch Enum from SimpleFontData and use Pitch enum values from
FixedPitchFontType

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192510

[h.joshi, 2015-03-20 04:31:30]

h.joshi@samsung.com changed reviewers:
+ dominik.rottsches@intel.com, eae@chromium.org

[h.joshi, 2015-03-20 04:31:46]

Pls Review.

[eae, 2015-03-20 15:39:25]

https://codereview.chromium.org/1020833002/diff/1/Source/platform/fonts/Fixed...
File Source/platform/fonts/FixedPitchFontType.h (right):

https://codereview.chromium.org/1020833002/diff/1/Source/platform/fonts/Fixed...
Source/platform/fonts/FixedPitchFontType.h:13: UnKnownPitchFont
Unknown (lowercase K).

https://codereview.chromium.org/1020833002/diff/1/Source/platform/fonts/FontF...
File Source/platform/fonts/FontFallbackList.cpp (right):

https://codereview.chromium.org/1020833002/diff/1/Source/platform/fonts/FontF...
Source/platform/fonts/FontFallbackList.cpp:86: m_pitch = NonFixedPitchFont;
VariablePitch is a much better name than NonFixedPitch, could we rename
NonFixedPitchFont to VariablePitchFont instead please?

[h.joshi, 2015-03-23 04:44:05]

@Emil: Made suggested changes.
Pls review.

https://codereview.chromium.org/1020833002/diff/1/Source/platform/fonts/Fixed...
File Source/platform/fonts/FixedPitchFontType.h (right):

https://codereview.chromium.org/1020833002/diff/1/Source/platform/fonts/Fixed...
Source/platform/fonts/FixedPitchFontType.h:13: UnKnownPitchFont
On 2015/03/20 15:39:24, eae wrote:
> Unknown (lowercase K).

Done.

https://codereview.chromium.org/1020833002/diff/1/Source/platform/fonts/FontF...
File Source/platform/fonts/FontFallbackList.cpp (right):

https://codereview.chromium.org/1020833002/diff/1/Source/platform/fonts/FontF...
Source/platform/fonts/FontFallbackList.cpp:86: m_pitch = NonFixedPitchFont;
On 2015/03/20 15:39:24, eae wrote:
> VariablePitch is a much better name than NonFixedPitch, could we rename
> NonFixedPitchFont to VariablePitchFont instead please?

Done.

[eae, 2015-03-23 17:13:33]

LGTM

[h.joshi, 2015-03-24 04:10:28]

Thank you Emil.

[h.joshi, 2015-03-24 04:10:38]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2015-03-24 04:10:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020833002/20001

[commit-bot: I haz the power, 2015-03-24 05:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 05:49:09]

Failed to apply patch for Source/core/css/CSSComputedStyleDeclaration.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSComputedStyleDeclaration.cpp
  Hunk #1 FAILED at 445.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/css/CSSComputedStyleDeclaration.cpp.rej

Patch:       Source/core/css/CSSComputedStyleDeclaration.cpp
Index: Source/core/css/CSSComputedStyleDeclaration.cpp
diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp
b/Source/core/css/CSSComputedStyleDeclaration.cpp
index
9dcdeb2d788106e47aae934fb2e111e50406c7f9..c36226f620791ffdcd59d0e64c6274414eaf2ed8
100644
--- a/Source/core/css/CSSComputedStyleDeclaration.cpp
+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp
@@ -445,11 +445,11 @@ PassRefPtrWillBeRawPtr<CSSValue>
CSSComputedStyleDeclaration::getFontSizeCSSValu
 FixedPitchFontType CSSComputedStyleDeclaration::fixedPitchFontType() const
 {
     if (!m_node)
-        return NonFixedPitchFont;
+        return VariablePitchFont;
 
     RefPtr<LayoutStyle> style =
m_node->computedStyle(m_pseudoElementSpecifier);
     if (!style)
-        return NonFixedPitchFont;
+        return VariablePitchFont;
 
     return style->fontDescription().fixedPitchFontType();
 }

[commit-bot: I haz the power, 2015-03-24 05:49:15]

The CQ bit was unchecked by commit-bot@chromium.org

[h.joshi, 2015-03-25 07:02:20]

The CQ bit was checked by h.joshi@samsung.com

[h.joshi, 2015-03-25 07:02:21]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1020833002/#ps40001
(title: "rebasing patch")

[commit-bot: I haz the power, 2015-03-25 07:02:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020833002/40001

[commit-bot: I haz the power, 2015-03-25 09:48:59]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192510