Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1020823003: Suppress MSI/MSM validation when building remoting MSI. (Closed)

Created:
5 years, 9 months ago by grt (UTC plus 2)
Modified:
5 years, 9 months ago
Reviewers:
garykac, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org, dxie
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress MSI/MSM validation when building remoting MSI. I believe this will unblock a required migration in our signing infrastructure. BUG=none R=garykac@chromium.org Committed: https://crrev.com/819da16a0d1246383bb8fe3c483fe7ace98a60b7 Cr-Commit-Position: refs/heads/master@{#321438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/host/installer/win/parameters.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
grt (UTC plus 2)
5 years, 9 months ago (2015-03-19 19:00:30 UTC) #1
Jamie
Can you be more specific? What exactly does this validation entail, and why is it ...
5 years, 9 months ago (2015-03-19 19:31:42 UTC) #3
Jamie
LGTM, but please let us know whether or not this fixes the problem (and revert ...
5 years, 9 months ago (2015-03-19 21:18:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020823003/1
5 years, 9 months ago (2015-03-19 21:22:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 21:46:14 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/819da16a0d1246383bb8fe3c483fe7ace98a60b7 Cr-Commit-Position: refs/heads/master@{#321438}
5 years, 9 months ago (2015-03-19 21:47:08 UTC) #8
grt (UTC plus 2)
5 years, 9 months ago (2015-03-20 17:53:03 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1028733002/ by grt@chromium.org.

The reason for reverting is: This did the trick. Reverting this change and
putting something durable in the signing infrastructure. Thanks..

Powered by Google App Engine
This is Rietveld 408576698