Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1020803002: Don't let unittests access LTH from the impl thread. (Closed)

Created:
5 years, 9 months ago by Ian Vollick
Modified:
5 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't let unittests access LTH from the impl thread. This causes racy sadness. BUG=235188 Committed: https://crrev.com/1aa849117446c8524275bd305226fee8859f0c6f Cr-Commit-Position: refs/heads/master@{#321398}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -24 lines) Patch
M cc/test/layer_tree_test.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 8 chunks +24 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Vollick
5 years, 9 months ago (2015-03-19 03:36:34 UTC) #2
danakj
LGTM w/ 1 question https://codereview.chromium.org/1020803002/diff/1/cc/test/layer_tree_test.cc File cc/test/layer_tree_test.cc (right): https://codereview.chromium.org/1020803002/diff/1/cc/test/layer_tree_test.cc#newcode882 cc/test/layer_tree_test.cc:882: DCHECK(!proxy() || proxy()->IsMainThread() || proxy()->IsMainThreadBlocked()); ...
5 years, 9 months ago (2015-03-19 16:37:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020803002/20001
5 years, 9 months ago (2015-03-19 17:46:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 18:49:20 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 18:50:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1aa849117446c8524275bd305226fee8859f0c6f
Cr-Commit-Position: refs/heads/master@{#321398}

Powered by Google App Engine
This is Rietveld 408576698