Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1020783002: Web MIDI (Linux): Improve id quality, create opaque id, prep for hotplug (Closed)

Created:
5 years, 9 months ago by Adam Goode
Modified:
5 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve id quality, create opaque id, prep for hotplug BUG=466721, 431489 Committed: https://crrev.com/eaea4405a27a01da0de837b09b542f54a31d5d00 Cr-Commit-Position: refs/heads/master@{#321412}

Patch Set 1 #

Patch Set 2 : Use enum class #

Patch Set 3 : Put note about SHA256 and use OpaqueKey for now #

Total comments: 2

Patch Set 4 : Use sizeof(hash) instead of repeating size constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -99 lines) Patch
M media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/midi/midi_manager_alsa.h View 1 4 chunks +65 lines, -15 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 2 3 17 chunks +226 lines, -73 lines 0 comments Download
M media/midi/midi_manager_alsa_unittest.cc View 1 1 chunk +52 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Adam Goode
wolenetz for media/DEPS agl for crypto/DEPS toyoshim for media/midi
5 years, 9 months ago (2015-03-19 11:57:34 UTC) #2
agl
LGTM https://codereview.chromium.org/1020783002/diff/40001/media/midi/midi_manager_alsa.cc File media/midi/midi_manager_alsa.cc (right): https://codereview.chromium.org/1020783002/diff/40001/media/midi/midi_manager_alsa.cc#newcode433 media/midi/midi_manager_alsa.cc:433: crypto::SHA256HashString(JSONValue(), &hash, crypto::kSHA256Length); the 3rd argument should be ...
5 years, 9 months ago (2015-03-19 12:05:18 UTC) #3
Takashi Toyoshima
lgtm for media/midi.
5 years, 9 months ago (2015-03-19 13:00:21 UTC) #4
Adam Goode
https://codereview.chromium.org/1020783002/diff/40001/media/midi/midi_manager_alsa.cc File media/midi/midi_manager_alsa.cc (right): https://codereview.chromium.org/1020783002/diff/40001/media/midi/midi_manager_alsa.cc#newcode433 media/midi/midi_manager_alsa.cc:433: crypto::SHA256HashString(JSONValue(), &hash, crypto::kSHA256Length); On 2015/03/19 12:05:18, agl wrote: > ...
5 years, 9 months ago (2015-03-19 16:48:32 UTC) #5
wolenetz
media/DEPS lgtm
5 years, 9 months ago (2015-03-19 19:43:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020783002/60001
5 years, 9 months ago (2015-03-19 19:49:48 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-19 19:53:32 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:54:05 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/eaea4405a27a01da0de837b09b542f54a31d5d00
Cr-Commit-Position: refs/heads/master@{#321412}

Powered by Google App Engine
This is Rietveld 408576698