[Media Router] Design MediaRouter interface with stub implementation.

chrome/browser/media/router/media_route.h

Index: chrome/browser/media/router/media_route.h
diff --git a/chrome/browser/media/router/media_route.h b/chrome/browser/media/router/media_route.h
index a8564f63d0449be3e7080ceed2bf795fcb69b8f7..c1fb2017e7ce0825c29ad597ad0317535073189d 100644
--- a/chrome/browser/media/router/media_route.h
+++ b/chrome/browser/media/router/media_route.h
@@ -18,8 +18,7 @@
 namespace media_router {
 
 using RouteRequestId = int64;
-
-class MediaRouteFactory;
+const RouteRequestId kInvalidRouteRequestId = -1;
 
 // For now, a simple transition graph: NEW -> CONNECTED -> CLOSED.
 enum MediaRouteState {
@@ -48,7 +47,6 @@ class MediaRoute {
              const MediaSink& media_sink,
              const std::string& description,
              bool is_local);
-
   ~MediaRoute();
 
   // The media route identifier.
@@ -75,12 +73,12 @@ class MediaRoute {
   bool Equals(const MediaRoute& other) const;
 
  private:
-  const MediaRouteId media_route_id_;
-  const MediaSource media_source_;
-  const MediaSink media_sink_;
-  const std::string description_;
-  const bool is_local_;
-  const MediaRouteState state_;
+  MediaRouteId media_route_id_;
+  MediaSource media_source_;
+  MediaSink media_sink_;
+  std::string description_;
+  bool is_local_;
+  MediaRouteState state_;

[xhwang, 2015/04/08 17:46:24]

MediaRoute is non-trivial: it has 6 members. I would prefer to make this
immutable (as you have in your comment above at l.34), keep these fields const
and make the class DISALLOW_COPY_AND_ASSIGN.

For using MediaRoute in stl containers, you can try using ScopedVector instead
of std::vector.

[imcheng, 2015/04/08 19:21:30]

MediaRoute is still a data class as it stands today; is there a reason why we
want to DISALLOW_COPY_AND_ASSIGN, other than that this object is not so small?

[xhwang, 2015/04/08 20:32:51]

Isn't "this class is not so small" a strong reason to use
DISALLOW_COPY_AND_ASSIGN?

[imcheng, 2015/04/08 23:28:09]

Per discussion, keep this for now. It is still immutable.

 };
 
 }  // namespace media_router