Issue 102073012: GTTF: only print the message about skipping retries when it actually applies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 102073012: GTTF: only print the message about skipping retries when it actually applies. (Closed)

Created:
6 years, 11 months ago by Paweł Hajdan Jr.

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), sky

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTTF: only print the message about skipping retries when it actually applies. Before the launcher would print it also when the limit of retries has been reached, which is different from doing less than requested number of retries because so many tests are failing. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243231

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -40 lines)			Patch
	M	base/test/launcher/test_launcher.cc	View	1	1 chunk	+41 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/102073012/diff/1/base/test/launcher/test_launcher.cc File base/test/launcher/test_launcher.cc (right): https://codereview.chromium.org/102073012/diff/1/base/test/launcher/test_launcher.cc#newcode510 base/test/launcher/test_launcher.cc:510: if (tests_to_retry_.empty() || nit: fit on one line.

6 years, 11 months ago (2014-01-06 19:27:38 UTC) #2

Paweł Hajdan Jr.

https://codereview.chromium.org/102073012/diff/1/base/test/launcher/test_launcher.cc File base/test/launcher/test_launcher.cc (right): https://codereview.chromium.org/102073012/diff/1/base/test/launcher/test_launcher.cc#newcode510 base/test/launcher/test_launcher.cc:510: if (tests_to_retry_.empty() || On 2014/01/06 19:27:39, sky wrote: > ...

6 years, 11 months ago (2014-01-07 09:19:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r243231.

Expand Messages | Collapse Messages