Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2212)

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 102073008: Allow multiple NaCl modules to be debugged. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/task_manager.h ('k') | chrome/browser/ui/cocoa/task_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/task_manager.cc
diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index efb88c9940ddb38c415dcdbfb1b4484202569ecd..04cbc2ba83a8ff2b9a828a34d6b5edcc325fa6a6 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -111,6 +111,7 @@ bool IsSharedByGroup(int col_id) {
case IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN:
case IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN:
case IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN:
+ case IDS_TASK_MANAGER_NACL_DEBUG_STUB_PORT_COLUMN:
return true;
default:
return false;
@@ -188,7 +189,9 @@ class TaskManagerModelGpuDataManagerObserver
};
TaskManagerModel::PerResourceValues::PerResourceValues()
- : is_title_valid(false),
+ : is_nacl_debug_stub_port_valid(false),
+ nacl_debug_stub_port(0),
+ is_title_valid(false),
is_profile_name_valid(false),
network_usage(0),
is_process_id_valid(false),
@@ -280,6 +283,15 @@ int TaskManagerModel::GroupCount() const {
return group_map_.size();
}
+int TaskManagerModel::GetNaClDebugStubPort(int index) const {
+ PerResourceValues& values(GetPerResourceValues(index));
+ if (!values.is_nacl_debug_stub_port_valid) {
+ values.is_nacl_debug_stub_port_valid = true;
+ values.nacl_debug_stub_port = GetResource(index)->GetNaClDebugStubPort();
+ }
+ return values.nacl_debug_stub_port;
+}
+
int64 TaskManagerModel::GetNetworkUsage(int index) const {
return GetNetworkUsage(GetResource(index));
}
@@ -373,6 +385,9 @@ base::string16 TaskManagerModel::GetResourceById(int index, int col_id) const {
case IDS_TASK_MANAGER_JAVASCRIPT_MEMORY_ALLOCATED_COLUMN:
return GetResourceV8MemoryAllocatedSize(index);
+ case IDS_TASK_MANAGER_NACL_DEBUG_STUB_PORT_COLUMN:
+ return GetResourceNaClDebugStubPort(index);
+
default:
NOTREACHED();
return base::string16();
@@ -398,6 +413,15 @@ const base::string16& TaskManagerModel::GetResourceProfileName(
return values.profile_name;
}
+base::string16 TaskManagerModel::GetResourceNaClDebugStubPort(int index) const {
+ int port = GetNaClDebugStubPort(index);
+ if (port == 0) {
+ return base::ASCIIToUTF16("N/A");
+ } else {
+ return base::IntToString16(port);
+ }
+}
+
base::string16 TaskManagerModel::GetResourceNetworkUsage(int index) const {
int64 net_usage = GetNetworkUsage(index);
if (net_usage == -1)
@@ -848,6 +872,10 @@ int TaskManagerModel::CompareValues(int row1, int row2, int col_id) const {
return ValueCompareMember(
this, &TaskManagerModel::GetPhysicalMemory, row1, row2);
+ case IDS_TASK_MANAGER_NACL_DEBUG_STUB_PORT_COLUMN:
+ return ValueCompare(GetNaClDebugStubPort(row1),
+ GetNaClDebugStubPort(row2));
+
case IDS_TASK_MANAGER_PROCESS_ID_COLUMN:
return ValueCompare(GetProcessId(row1), GetProcessId(row2));
« no previous file with comments | « chrome/browser/task_manager/task_manager.h ('k') | chrome/browser/ui/cocoa/task_manager_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698