Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2814)

Unified Diff: chrome/browser/task_manager/child_process_resource_provider.cc

Issue 102073008: Allow multiple NaCl modules to be debugged. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/child_process_resource_provider.cc
diff --git a/chrome/browser/task_manager/child_process_resource_provider.cc b/chrome/browser/task_manager/child_process_resource_provider.cc
index 1639bb4eb858908fc42f3be599401b49a9efca74..685c80e883ecf85e6eeca75fdc209ad5589d59b8 100644
--- a/chrome/browser/task_manager/child_process_resource_provider.cc
+++ b/chrome/browser/task_manager/child_process_resource_provider.cc
@@ -31,10 +31,12 @@ class ChildProcessResource : public Resource {
ChildProcessResource(int process_type,
const base::string16& name,
base::ProcessHandle handle,
- int unique_process_id);
+ int unique_process_id,
+ int nacl_debug_stub_port);
virtual ~ChildProcessResource();
// Resource methods:
+ virtual int GetNaClDebugStubPort() const OVERRIDE;
virtual base::string16 GetTitle() const OVERRIDE;
virtual base::string16 GetProfileName() const OVERRIDE;
virtual gfx::ImageSkia GetIcon() const OVERRIDE;
@@ -57,6 +59,7 @@ class ChildProcessResource : public Resource {
base::ProcessHandle handle_;
int pid_;
int unique_process_id_;
+ int nacl_debug_stub_port_;
mutable base::string16 title_;
bool network_usage_support_;
@@ -74,11 +77,13 @@ ChildProcessResource::ChildProcessResource(
int process_type,
const base::string16& name,
base::ProcessHandle handle,
- int unique_process_id)
+ int unique_process_id,
+ int nacl_debug_stub_port)
: process_type_(process_type),
name_(name),
handle_(handle),
unique_process_id_(unique_process_id),
+ nacl_debug_stub_port_(nacl_debug_stub_port),
network_usage_support_(false) {
// We cache the process id because it's not cheap to calculate, and it won't
// be available when we get the plugin disconnected notification.
@@ -94,6 +99,10 @@ ChildProcessResource::~ChildProcessResource() {
}
// Resource methods:
+int ChildProcessResource::GetNaClDebugStubPort() const {
+ return nacl_debug_stub_port_;
+}
+
base::string16 ChildProcessResource::GetTitle() const {
if (title_.empty())
title_ = GetLocalizedTitle();
@@ -309,7 +318,8 @@ void ChildProcessResourceProvider::AddToTaskManager(
child_process_data.process_type,
child_process_data.name,
child_process_data.handle,
- child_process_data.id);
+ child_process_data.id,
+ child_process_data.nacl_debug_stub_port);
resources_[child_process_data.handle] = resource;
pid_to_resources_[resource->process_id()] = resource;
task_manager_->AddResource(resource);

Powered by Google App Engine
This is Rietveld 408576698