Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 102073007: Have component_strings be a hard dependency (Closed)

Created:
7 years ago by blundell
Modified:
7 years ago
Reviewers:
Jói
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Have component_strings be a hard dependency As this target generates a header, it must be a hard dependency. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
components/component_strings.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blundell
7 years ago (2013-12-10 13:51:17 UTC) #1
Jói
LGTM On Tue, Dec 10, 2013 at 1:51 PM, <blundell@chromium.org> wrote: > Reviewers: Jói, > ...
7 years ago (2013-12-10 13:52:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/102073007/1
7 years ago (2013-12-10 13:53:33 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-10 18:13:47 UTC) #4
Message was sent while issue was closed.
Change committed as 239805

Powered by Google App Engine
This is Rietveld 408576698