Issue 102073002: Remove TextTrackCueBox

Issue 102073002: Remove TextTrackCueBox (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
acolwell GONE FROM CHROMIUM, adamk

CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove TextTrackCueBox It is only used by the VTT code, so keep only VTTCueBox. BUG=270340 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163149

Patch Set 2 : inline pseudo id #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -57 lines)			Patch
M	Source/core/html/track/TextTrackCue.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	Source/core/html/track/TextTrackCue.cpp	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTCue.h	View		4 chunks	+3 lines, -7 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTCue.cpp	View	1	6 chunks	+6 lines, -10 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTRegion.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTRegion.cpp	View		5 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

lgtm % nit https://codereview.chromium.org/102073002/diff/1/Source/core/html/track/vtt/VTTCue.cpp File Source/core/html/track/vtt/VTTCue.cpp (right): https://codereview.chromium.org/102073002/diff/1/Source/core/html/track/vtt/VTTCue.cpp#newcode129 Source/core/html/track/vtt/VTTCue.cpp:129: DEFINE_STATIC_LOCAL(const AtomicString, trackDisplayBoxShadowPseudoId, ("-webkit-media-text-track-display", AtomicString::ConstructFromLiteral)); nit: ...

7 years ago (2013-12-03 20:51:31 UTC) #2

philipj_slow

https://codereview.chromium.org/102073002/diff/1/Source/core/html/track/vtt/VTTCue.cpp File Source/core/html/track/vtt/VTTCue.cpp (right): https://codereview.chromium.org/102073002/diff/1/Source/core/html/track/vtt/VTTCue.cpp#newcode129 Source/core/html/track/vtt/VTTCue.cpp:129: DEFINE_STATIC_LOCAL(const AtomicString, trackDisplayBoxShadowPseudoId, ("-webkit-media-text-track-display", AtomicString::ConstructFromLiteral)); On 2013/12/03 20:51:31, acolwell ...

7 years ago (2013-12-03 21:16:23 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/102073002/20001

7 years ago (2013-12-03 21:18:20 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=14414

7 years ago (2013-12-03 23:16:04 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/102073002/20001

7 years ago (2013-12-04 07:26:52 UTC) #7

Message was sent while issue was closed.

Change committed as 163149

Expand Messages | Collapse Messages