extensions/browser/PRESUBMIT.py - Issue 1020663002: [Extensions] Don't check extension histogram on commit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/PRESUBMIT.py

Issue 1020663002: [Extensions] Don't check extension histogram on commit Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Chromium presubmit script for src/extensions/browser.	5 """Chromium presubmit script for src/extensions/browser.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details on the presubmit API built into depot_tools.	8 for more details on the presubmit API built into depot_tools.

9 """	9 """

10	10

(...skipping 12 matching lines...) Expand all Loading...
23	23

24 return StrictEnumValueChecker(input_api, output_api,	24 return StrictEnumValueChecker(input_api, output_api,

25 start_marker='enum HistogramValue {', end_marker=' // Last entry:',	25 start_marker='enum HistogramValue {', end_marker=' // Last entry:',

26 path='extensions/browser/extension_function_histogram_value.h')	26 path='extensions/browser/extension_function_histogram_value.h')

27	27

28 def CheckChangeOnUpload(input_api, output_api):	28 def CheckChangeOnUpload(input_api, output_api):

29 results = []	29 results = []

30 results += _CreateHistogramValueChecker(input_api, output_api).Run()	30 results += _CreateHistogramValueChecker(input_api, output_api).Run()

31 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)	31 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

32 return results	32 return results

33

34 def CheckChangeOnCommit(input_api, output_api):

35 return _CreateHistogramValueChecker(input_api, output_api).Run()

OLD	NEW