Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1020633002: Fix failure in NetUtilTest.IDNToUnicodeFast running on Chromecast. (Closed)

Created:
5 years, 9 months ago by halliwell
Modified:
5 years, 9 months ago
Reviewers:
pauljensen, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix failure in NetUtilTest.IDNToUnicodeFast running on Chromecast. Tracked the failure down to this function. Looks like a simple typo, test passes now. BUG=internal b/19821810 Committed: https://crrev.com/51cb75c99f3194cbb61738703a3573496a58e07e Cr-Commit-Position: refs/heads/master@{#321627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/base/net_util_icu.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
halliwell
5 years, 9 months ago (2015-03-18 21:54:12 UTC) #2
halliwell
5 years, 9 months ago (2015-03-19 23:44:00 UTC) #4
mmenke
The fix LGTM, but do you have any idea why this was only failing on ...
5 years, 9 months ago (2015-03-20 13:35:53 UTC) #5
pauljensen
Could we add a test for this to net_util_icu_unittest.cc?
5 years, 9 months ago (2015-03-20 13:38:01 UTC) #6
halliwell
On 2015/03/20 13:38:01, pauljensen wrote: > Could we add a test for this to net_util_icu_unittest.cc? ...
5 years, 9 months ago (2015-03-20 13:49:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020633002/1
5 years, 9 months ago (2015-03-20 19:12:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 20:54:19 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 20:55:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51cb75c99f3194cbb61738703a3573496a58e07e
Cr-Commit-Position: refs/heads/master@{#321627}

Powered by Google App Engine
This is Rietveld 408576698