Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: ui/native_theme/fallback_theme.cc

Issue 1020623002: [AiS] adding positive and negative theme values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge from master Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/native_theme/fallback_theme.cc
diff --git a/ui/native_theme/fallback_theme.cc b/ui/native_theme/fallback_theme.cc
index 127243fdde09bf88e5507eaca712f2ca5819fb96..45fd47251b2a72badb897e7b35714cfbc1c865d9 100644
--- a/ui/native_theme/fallback_theme.cc
+++ b/ui/native_theme/fallback_theme.cc
@@ -89,6 +89,22 @@ SkColor FallbackTheme::GetSystemColor(ColorId color_id) const {
kResultsTableHoveredText, kResultsTableHoveredBackground, 0x34);
static const SkColor kResultsTabSelectedDivider = color_utils::AlphaBlend(
kResultsTableSelectedText, kTextfieldSelectionBackgroundFocused, 0x34);
+ static const SkColor kResultsTablePositiveText =
+ color_utils::AlphaBlend(SK_ColorGREEN, kTextfieldDefaultBackground, 0xDD);
+ static const SkColor kResultsTablePositiveHoveredText =
+ color_utils::AlphaBlend(SK_ColorGREEN, kResultsTableHoveredBackground,
+ 0xDD);
+ static const SkColor kResultsTablePositiveSelectedText =
+ color_utils::AlphaBlend(SK_ColorGREEN,
+ kTextfieldSelectionBackgroundFocused, 0xDD);
msw 2015/03/19 21:39:23 nit: we could drop 'Focused' from this constant an
Peter Kasting 2015/03/19 22:17:53 Good call, added that to the cleanup bug I have on
+ static const SkColor kResultsTableNegativeText =
+ color_utils::AlphaBlend(SK_ColorRED, kTextfieldDefaultBackground, 0xDD);
+ static const SkColor kResultsTableNegativeHoveredText =
+ color_utils::AlphaBlend(SK_ColorRED, kResultsTableHoveredBackground,
+ 0xDD);
+ static const SkColor kResultsTableNegativeSelectedText =
+ color_utils::AlphaBlend(SK_ColorRED, kTextfieldSelectionBackgroundFocused,
+ 0xDD);
SkColor color;
if (CommonThemeGetSystemColor(color_id, &color))
@@ -205,6 +221,18 @@ SkColor FallbackTheme::GetSystemColor(ColorId color_id) const {
return kResultsTableHoveredDivider;
case kColorId_ResultsTableSelectedDivider:
return kResultsTabSelectedDivider;
+ case kColorId_ResultsTablePositiveText:
+ return kResultsTablePositiveText;
+ case kColorId_ResultsTablePositiveHoveredText:
+ return kResultsTablePositiveHoveredText;
+ case kColorId_ResultsTablePositiveSelectedText:
+ return kResultsTablePositiveSelectedText;
+ case kColorId_ResultsTableNegativeText:
+ return kResultsTableNegativeText;
+ case kColorId_ResultsTableNegativeHoveredText:
+ return kResultsTableNegativeHoveredText;
+ case kColorId_ResultsTableNegativeSelectedText:
+ return kResultsTableNegativeSelectedText;
default:
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698